[webkit-changes] [WebKit/WebKit] 69d470: [JSC] Add ALWAYS_INLINE_LAMBDA to some collectMatc...
Yusuke Suzuki
noreply at github.com
Tue Aug 22 20:05:38 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 69d47072729f75c2ffc006c29a5ac00731a99aef
https://github.com/WebKit/WebKit/commit/69d47072729f75c2ffc006c29a5ac00731a99aef
Author: Yusuke Suzuki <ysuzuki at apple.com>
Date: 2023-08-22 (Tue, 22 Aug 2023)
Changed paths:
M Source/JavaScriptCore/dfg/DFGOperations.cpp
M Source/JavaScriptCore/runtime/RegExpObject.cpp
M Source/JavaScriptCore/runtime/RegExpObjectInlines.h
M Source/WTF/wtf/Compiler.h
Log Message:
-----------
[JSC] Add ALWAYS_INLINE_LAMBDA to some collectMatches lambdas
https://bugs.webkit.org/show_bug.cgi?id=260564
rdar://114293708
Reviewed by Justin Michaud.
This patch attaches always_inline attribute to some collectMatches lambdas.
We found that WSL gets regressed from 267071 at main. And we found that this slight
change made these critical functions non-inlined, causing severe regression.
Now because we already know that they should be inlined, this patch attaches
always_inline attribute to these lambdas. We add ALWAYS_INLINE_LAMBDA, which
is usable for lambda.
* Source/JavaScriptCore/dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
* Source/JavaScriptCore/runtime/RegExpObject.cpp:
(JSC::RegExpObject::matchGlobal):
* Source/JavaScriptCore/runtime/RegExpObjectInlines.h:
(JSC::collectMatches):
* Source/WTF/wtf/Compiler.h:
Canonical link: https://commits.webkit.org/267176@main
More information about the webkit-changes
mailing list