[webkit-changes] [WebKit/WebKit] fe2039: Remove (mostly) unused AppBundle code from webpushd

[Brady Eidson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fe2039934e79ead26db6ab49ec33be75b5f2e1da
      https://github.com/WebKit/WebKit/commit/fe2039934e79ead26db6ab49ec33be75b5f2e1da
  Author: Brady Eidson <beidson at apple.com>
  Date:   2023-08-22 (Tue, 22 Aug 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkProcess.h
    M Source/WebKit/NetworkProcess/NetworkProcess.messages.in
    M Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp
    M Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.h
    M Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.h
    M Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.messages.in
    M Source/WebKit/Shared/WebPushDaemonConstants.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
    M Source/WebKit/UIProcess/Notifications/ServiceWorkerNotificationHandler.cpp
    M Source/WebKit/UIProcess/Notifications/ServiceWorkerNotificationHandler.h
    M Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp
    M Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/Notifications/NotificationPermissionRequestManager.cpp
    R Source/WebKit/webpushd/AppBundleRequest.h
    R Source/WebKit/webpushd/AppBundleRequest.mm
    R Source/WebKit/webpushd/ICAppBundle.h
    R Source/WebKit/webpushd/ICAppBundle.mm
    R Source/WebKit/webpushd/InstallCoordinationSPI.h
    R Source/WebKit/webpushd/MockAppBundleForTesting.h
    R Source/WebKit/webpushd/MockAppBundleForTesting.mm
    R Source/WebKit/webpushd/MockAppBundleRegistry.h
    R Source/WebKit/webpushd/MockAppBundleRegistry.mm
    R Source/WebKit/webpushd/PushAppBundle.h
    R Source/WebKit/webpushd/PushAppBundle.mm
    M Source/WebKit/webpushd/PushClientConnection.h
    M Source/WebKit/webpushd/PushClientConnection.mm
    M Source/WebKit/webpushd/WebPushDaemon.h
    M Source/WebKit/webpushd/WebPushDaemon.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm

  Log Message:
  -----------
  Remove (mostly) unused AppBundle code from webpushd
https://bugs.webkit.org/show_bug.cgi?id=260549
rdar://114283091

Reviewed by Alex Christensen.

This code was part of an early design direction in webpushd that went nowhere, and only ended up
being (lightly) used for some API tests.

Removing it will simplify future refactoring.

* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::getOriginsWithPushAndNotificationPermissions): Deleted.
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
* Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp:
(WebKit::NetworkNotificationManager::requestSystemNotificationPermission): Deleted.
(WebKit::NetworkNotificationManager::getOriginsWithPushAndNotificationPermissions): Deleted.
* Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.h:
* Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.h:
* Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.messages.in:
* Source/WebKit/Shared/WebPushDaemonConstants.h:
(WebKit::WebPushD::messageTypeSendsReply):
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _deletePushAndNotificationRegistration:completionHandler:]): Deleted.
(-[WKWebsiteDataStore _getOriginsWithPushAndNotificationPermissions:]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::getOriginsWithPushAndNotificationPermissions): Deleted.
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:
* Source/WebKit/UIProcess/Notifications/ServiceWorkerNotificationHandler.cpp:
(WebKit::ServiceWorkerNotificationHandler::requestSystemNotificationPermission): Deleted.
* Source/WebKit/UIProcess/Notifications/ServiceWorkerNotificationHandler.h:
* Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp:
(WebKit::WebNotificationManagerMessageHandler::requestSystemNotificationPermission): Deleted.
* Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::startRequest):
* Source/WebKit/webpushd/AppBundleRequest.h: Removed.
* Source/WebKit/webpushd/AppBundleRequest.mm: Removed.
* Source/WebKit/webpushd/ICAppBundle.h: Removed.
* Source/WebKit/webpushd/ICAppBundle.mm: Removed.
* Source/WebKit/webpushd/InstallCoordinationSPI.h: Removed.
* Source/WebKit/webpushd/MockAppBundleForTesting.h: Removed.
* Source/WebKit/webpushd/MockAppBundleForTesting.mm: Removed.
* Source/WebKit/webpushd/MockAppBundleRegistry.h: Removed.
* Source/WebKit/webpushd/MockAppBundleRegistry.mm: Removed.
* Source/WebKit/webpushd/PushAppBundle.h: Removed.
* Source/WebKit/webpushd/PushAppBundle.mm: Removed.
* Source/WebKit/webpushd/PushClientConnection.h:
* Source/WebKit/webpushd/PushClientConnection.mm:
(WebPushD::PushClientConnection::connectionClosed):
(WebPushD::PushClientConnection::enqueueAppBundleRequest): Deleted.
(WebPushD::PushClientConnection::maybeStartNextAppBundleRequest): Deleted.
(WebPushD::PushClientConnection::didCompleteAppBundleRequest): Deleted.
* Source/WebKit/webpushd/WebPushDaemon.h:
* Source/WebKit/webpushd/WebPushDaemon.mm:
(WebPushD::WebPushDaemon::decodeAndHandleMessage):
(WebPushD::WebPushDaemon::deletePushAndNotificationRegistration):
(WebPushD::MessageInfo::getOriginsWithPushAndNotificationPermissions::encodeReply): Deleted.
(WebPushD::MessageInfo::requestSystemNotificationPermission::encodeReply): Deleted.
(WebPushD::WebPushDaemon::requestSystemNotificationPermission): Deleted.
(WebPushD::WebPushDaemon::getOriginsWithPushAndNotificationPermissions): Deleted.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:

Canonical link: https://commits.webkit.org/267168@main