[webkit-changes] [WebKit/WebKit] 25f43a: Add ScopedName type

Antti Koivisto noreply at github.com
Tue Aug 22 09:04:46 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 25f43abc6e10e195a41db5db0b383bef04a208ac
      https://github.com/WebKit/WebKit/commit/25f43abc6e10e195a41db5db0b383bef04a208ac
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-08-22 (Tue, 22 Aug 2023)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/animation/CSSAnimation.cpp
    M Source/WebCore/animation/KeyframeEffect.cpp
    M Source/WebCore/css/CSSToStyleMap.cpp
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/platform/animation/Animation.cpp
    M Source/WebCore/platform/animation/Animation.h
    A Source/WebCore/style/ScopedName.h
    M Source/WebCore/style/Styleable.cpp

  Log Message:
  -----------
  Add ScopedName type
https://bugs.webkit.org/show_bug.cgi?id=260493
rdar://114224001

Reviewed by Alan Baradlay.

Refactor animation name type to a generic struct. There are some other things in CSS
that need scoped names too.

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::CSSAnimation):
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::getKeyframes):
(WebCore::KeyframeEffect::computeCSSAnimationBlendingKeyframes):
* Source/WebCore/css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationName):
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::valueForScopedName):
(WebCore::ComputedStyleExtractor::addValueForAnimationPropertyToList):
(WebCore::valueForAnimationName): Deleted.
* Source/WebCore/platform/animation/Animation.cpp:
(WebCore::Animation::Animation):
(WebCore::Animation::animationsMatch const):
(WebCore::Animation::initialName const):
(WebCore::operator<<):
* Source/WebCore/platform/animation/Animation.h:
(WebCore::Animation::isValidAnimation const):
(WebCore::Animation::name const):
(WebCore::Animation::setName):
(WebCore::Animation::nameStyleScopeOrdinal const): Deleted.
* Source/WebCore/style/ScopedName.h: Added.
* Source/WebCore/style/Styleable.cpp:
(WebCore::keyframesRuleExistsForAnimation):
(WebCore::Styleable::animationListContainsNewlyValidAnimation const):
(WebCore::Styleable::updateCSSAnimations const):

Canonical link: https://commits.webkit.org/267135@main




More information about the webkit-changes mailing list