[webkit-changes] [WebKit/WebKit] ce7e7d: TestWTF tests compilation unit names clash with WT...

[Elliott Williams]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ce7e7da9c4dc1f34865b5e242364bea28dbf9eb5
      https://github.com/WebKit/WebKit/commit/ce7e7da9c4dc1f34865b5e242364bea28dbf9eb5
  Author: Elliott Williams <emw at apple.com>
  Date:   2023-08-21 (Mon, 21 Aug 2023)

  Changed paths:
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj

  Log Message:
  -----------
  TestWTF tests compilation unit names clash with WTF implementation compilation unit names, causing linker warnings
https://bugs.webkit.org/show_bug.cgi?id=224860
rdar://problem/77255847

Reviewed by Alexey Proskuryakov.

libWTF.a was being merged into libTestWTF.a, causing a
naming collision that resulted in thousands of warnings like

    Libtool libTestWTF
    /Volumes/.../usr/bin/libtool: warning same member name (AtomString.o) in output file used for input files:

and

    GenerateDSYMFile TestWTF.dSYM
    warning: (x86_64)  could not find object file symbol for symbol __ZNK3WTF10AtomString23convertToASCIILowercaseEv

Instead, move the linkage of libWTF.a down into the TestWTF binary.
Tests in TestWTF can have the same file name as their implementation in
WTF without symbol name collisions, because they are never part of the
same static archive.

* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/267099@main