[webkit-changes] [WebKit/WebKit] ecfc5a: [import-w3c-tests] Get rid of all --src-dir differ...

Sam Sneddon noreply at github.com
Mon Aug 21 09:29:04 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ecfc5a0bd2a89262511e1f9fa8a7e01dc5421de7
      https://github.com/WebKit/WebKit/commit/ecfc5a0bd2a89262511e1f9fa8a7e01dc5421de7
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2023-08-21 (Mon, 21 Aug 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/w3c/test_downloader.py
    M Tools/Scripts/webkitpy/w3c/test_importer.py
    M Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

  Log Message:
  -----------
  [import-w3c-tests] Get rid of all --src-dir differences
https://bugs.webkit.org/show_bug.cgi?id=260349
rdar://problem/114027584

Reviewed by Jonathan Bedard.

At this point, there are almost no differences left between passing
--src-dir and not: the only difference left is that we implicitly skip
several directories with --src-dir.

If we drop this difference, we can avoid the entire first copying step
when running without --src-dir, as all the downloader has to do is
create the WPT clone to import from, the same as if a WPT clone had been
specified via --src-dir.

* Tools/Scripts/webkitpy/w3c/test_downloader.py:
(TestDownloader.update_import_expectations):
(TestDownloader.download_tests):
(TestDownloader._add_test_suite_paths): Deleted.
(TestDownloader._empty_directory): Deleted.
(TestDownloader.copy_tests): Deleted.
(TestDownloader.copy_tests.longest_path): Deleted.
(TestDownloader.copy_tests.should_copy_dir): Deleted.
(TestDownloader.copy_tests.should_copy_file): Deleted.
* Tools/Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.__init__):
(TestImporter.do_import):
(TestImporter.find_importable_tests):
(TestImporter.find_importable_tests.should_keep_subdir): Deleted.
* Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:

Canonical link: https://commits.webkit.org/267091@main




More information about the webkit-changes mailing list