[webkit-changes] [WebKit/WebKit] 2cf981: [GStreamer] Harness: Basic segment handling

Philippe Normand noreply at github.com
Mon Aug 21 03:21:10 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2cf98196e729c6217a83c7ded6be8801eddf517a
      https://github.com/WebKit/WebKit/commit/2cf98196e729c6217a83c7ded6be8801eddf517a
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-08-21 (Mon, 21 Aug 2023)

  Changed paths:
    M Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp
    M Source/WebCore/platform/gstreamer/GStreamerElementHarness.h

  Log Message:
  -----------
  [GStreamer] Harness: Basic segment handling
https://bugs.webkit.org/show_bug.cgi?id=260424

Reviewed by Xabier Rodriguez-Calvar.

The pushSample API is now able to use the segment information from the sample, if it's available.
The corresponding sticky segment event is then coherent.

Flush handling also needed a change, after flush-stop we should re-push a segment event, but we were
not doing it, leading to runtime GStreamer warnings.

* Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp:
(WebCore::GStreamerElementHarness::start):
(WebCore::GStreamerElementHarness::pushStickyEvents):
(WebCore::GStreamerElementHarness::pushSegmentEvent):
(WebCore::GStreamerElementHarness::pushSample):
(WebCore::GStreamerElementHarness::pushBuffer):
(WebCore::GStreamerElementHarness::flush):
(WebCore::GStreamerElementHarness::flushBuffers):
* Source/WebCore/platform/gstreamer/GStreamerElementHarness.h:
(WebCore::GStreamerElementHarness::start):
(WebCore::GStreamerElementHarness::pushStickyEvents):
(WebCore::GStreamerElementHarness::pushSegmentEvent):

Canonical link: https://commits.webkit.org/267083@main




More information about the webkit-changes mailing list