[webkit-changes] [WebKit/WebKit] 590303: [Cocoa] Replace uses of CMNotificationCenter with ...

aestes noreply at github.com
Sun Aug 20 15:49:09 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5903034893af12971f9b3ee3426abaaa710d5af1
      https://github.com/WebKit/WebKit/commit/5903034893af12971f9b3ee3426abaaa710d5af1
  Author: Andy Estes <aestes at apple.com>
  Date:   2023-08-20 (Sun, 20 Aug 2023)

  Changed paths:
    M Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp
    M Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h
    M Source/WebCore/PAL/pal/cocoa/MediaToolboxSoftLink.h
    M Source/WebCore/PAL/pal/spi/cf/CoreMediaSPI.h
    M Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
    M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm
    M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm
    M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm

  Log Message:
  -----------
  [Cocoa] Replace uses of CMNotificationCenter with CFNotificationCenter
https://bugs.webkit.org/show_bug.cgi?id=260415
rdar://112505255

Reviewed by Eric Carlson.

CMNotificationCenter is SPI that wraps CFNotificationCenter API on Cocoa platforms. As such, this PR
replaces its usage in WebKit with CFNotificationCenter. While here, this PR removes the code that
observed kCMSampleBufferConsumerNotification_BufferConsumed since
-[AVSampleBufferDisplayLayer prerollDecodeWithCompletionHandler:] is available on all OS versions
supported on main.

* Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp:
* Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h:
* Source/WebCore/PAL/pal/cocoa/MediaToolboxSoftLink.h:
* Source/WebCore/PAL/pal/spi/cf/CoreMediaSPI.h:
* Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h:
* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::timebaseEffectiveRateChangedCallback):
(WebCore::EffectiveRateChangedListener::stop):
(WebCore::EffectiveRateChangedListener::EffectiveRateChangedListener):
(WebCore::CMTimebaseEffectiveRateChangedCallback): Deleted.
* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::m_logIdentifier):
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::enqueueSample):
(WebCore::bufferWasConsumedCallback): Deleted.
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::webProcessPoolHighDynamicRangeDidChangeCallback):
(WebKit::WebProcessPool::registerHighDynamicRangeChangeCallback):

Canonical link: https://commits.webkit.org/267078@main




More information about the webkit-changes mailing list