[webkit-changes] [WebKit/WebKit] 75237e: [GTK][WPE] Pass GBM_BO_USE_RENDERING to gbm_bo_create

Carlos Garcia Campos noreply at github.com
Sat Aug 19 08:43:07 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75237ef8a286cf001c769d682a54dc8ffaa5d05c
      https://github.com/WebKit/WebKit/commit/75237ef8a286cf001c769d682a54dc8ffaa5d05c
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-08-19 (Sat, 19 Aug 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp
    M Source/WebKit/WebProcess/WebPage/gtk/AcceleratedSurfaceDMABuf.cpp

  Log Message:
  -----------
  [GTK][WPE] Pass GBM_BO_USE_RENDERING to gbm_bo_create
https://bugs.webkit.org/show_bug.cgi?id=260431

Reviewed by Michael Catanzaro.

I suspect nvidia GBM implementation defaults to GBM_BO_USE_SCANOUT when
no flags are passed and then tries to create KMS dumb buffers. In any
case, using GBM_BO_USE_RENDERING is correct since those buffers are
created in the web process for rendering (as a color buffer storage).

* Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp:
(WebCore::GBMBufferSwapchain::getBuffer):
* Source/WebKit/WebProcess/WebPage/gtk/AcceleratedSurfaceDMABuf.cpp:
(WebKit::AcceleratedSurfaceDMABuf::RenderTargetEGLImage::create):

Canonical link: https://commits.webkit.org/267070@main




More information about the webkit-changes mailing list