[webkit-changes] [WebKit/WebKit] 4c5bf8: [visionOS] Safari YouTube audio location stays sta...

mwyrzykowski noreply at github.com
Thu Aug 17 17:01:16 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4c5bf811e466e891172125319aa6ef7fb4003795
      https://github.com/WebKit/WebKit/commit/4c5bf811e466e891172125319aa6ef7fb4003795
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-08-17 (Thu, 17 Aug 2023)

  Changed paths:
    M Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm

  Log Message:
  -----------
  [visionOS] Safari YouTube audio location stays stationary when window is moved while viewing other tab (audio is not spatial)
https://bugs.webkit.org/show_bug.cgi?id=260364
<radar://112181086>

Reviewed by Andy Estes.

Set the STSLabel when the viewer becomes invisible so audio follows the scene.

Set it back to nil when the viewer becomes visible to restore the current behavior.

* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setPageIsVisible):

* Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h:
Stage SPI for non-internal clients.

Canonical link: https://commits.webkit.org/267018@main




More information about the webkit-changes mailing list