[webkit-changes] [WebKit/WebKit] 121c1a: Remove ShadowRoot::resetStyleInheritance mechanism

Antti Koivisto noreply at github.com
Thu Aug 17 08:09:50 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 121c1a436df1474c86708c050d6f5577ba86f125
      https://github.com/WebKit/WebKit/commit/121c1a436df1474c86708c050d6f5577ba86f125
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-08-17 (Thu, 17 Aug 2023)

  Changed paths:
    M Source/WebCore/dom/ShadowRoot.cpp
    M Source/WebCore/dom/ShadowRoot.h
    M Source/WebCore/html/HTMLPlugInElement.cpp
    M Source/WebCore/html/shadow/ShadowPseudoIds.cpp
    M Source/WebCore/html/shadow/ShadowPseudoIds.h
    M Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp
    M Source/WebCore/style/StyleResolver.cpp

  Log Message:
  -----------
  Remove ShadowRoot::resetStyleInheritance mechanism
https://bugs.webkit.org/show_bug.cgi?id=260338
rdar://114015755

Reviewed by Alan Baradlay.

UA shadow trees should just use 'all: initial' if needed.

* Source/WebCore/dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::setResetStyleInheritance): Deleted.
* Source/WebCore/dom/ShadowRoot.h:
* Source/WebCore/html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::didAddUserAgentShadowRoot):
* Source/WebCore/html/shadow/ShadowPseudoIds.cpp:
(WebCore::ShadowPseudoIds::webkitPluginReplacement): Deleted.

Also remove this non-referenced pseudo element name.

* Source/WebCore/html/shadow/ShadowPseudoIds.h:
* Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp:

This is the only client for the mechanism, use 'all:initial' instead.

(WebCore::YouTubeEmbedShadowElement::create):
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::Resolver::State::State):

Canonical link: https://commits.webkit.org/266999@main




More information about the webkit-changes mailing list