[webkit-changes] [WebKit/WebKit] 6c660b: jsc.cpp(3614, 1): warning: function declared 'noret...

Fujii Hironori noreply at github.com
Thu Aug 17 02:30:47 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6c660bb7b4f5b27281db488bcb8890cee00a1f0b
      https://github.com/WebKit/WebKit/commit/6c660bb7b4f5b27281db488bcb8890cee00a1f0b
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2023-08-17 (Thu, 17 Aug 2023)

  Changed paths:
    M Source/WTF/wtf/Assertions.cpp
    M Source/WTF/wtf/Compiler.h

  Log Message:
  -----------
  jsc.cpp(3614,1): warning: function declared 'noreturn' should not return
https://bugs.webkit.org/show_bug.cgi?id=260330

Reviewed by Ross Kirsling.

clang-cl reported the following warnings for Windows port.

> WTF\wtf\Assertions.cpp(335,1): warning: function declared 'noreturn' should not return [-Winvalid-noreturn]
> JavaScriptCore\jsc.cpp(2602,1): warning: non-void function does not return a value [-Wreturn-type]
> JavaScriptCore\jsc.cpp(3614,1): warning: function declared 'noreturn' should not return [-Winvalid-noreturn]

Clang-cl should take a code path of GCC for UNUSED_FUNCTION, NO_RETURN
and NO_RETURN_WITH_VALUE macros to suppress compiler warnings.

* Source/WTF/wtf/Assertions.cpp:
* Source/WTF/wtf/Compiler.h:

Canonical link: https://commits.webkit.org/266995@main




More information about the webkit-changes mailing list