[webkit-changes] [WebKit/WebKit] e99342: StyleImages need to know if they are painting a fi...

Antti Koivisto noreply at github.com
Wed Aug 16 22:10:20 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e993429b13d827f663f596be484fa14cce95b6b1
      https://github.com/WebKit/WebKit/commit/e993429b13d827f663f596be484fa14cce95b6b1
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-08-16 (Wed, 16 Aug 2023)

  Changed paths:
    M Source/WebCore/css/CSSGradientValue.cpp
    M Source/WebCore/rendering/BackgroundPainter.cpp
    M Source/WebCore/rendering/style/StyleCachedImage.cpp
    M Source/WebCore/rendering/style/StyleCachedImage.h
    M Source/WebCore/rendering/style/StyleCanvasImage.cpp
    M Source/WebCore/rendering/style/StyleCanvasImage.h
    M Source/WebCore/rendering/style/StyleCrossfadeImage.cpp
    M Source/WebCore/rendering/style/StyleCrossfadeImage.h
    M Source/WebCore/rendering/style/StyleFilterImage.cpp
    M Source/WebCore/rendering/style/StyleFilterImage.h
    M Source/WebCore/rendering/style/StyleGradientImage.cpp
    M Source/WebCore/rendering/style/StyleGradientImage.h
    M Source/WebCore/rendering/style/StyleImage.h
    M Source/WebCore/rendering/style/StyleInvalidImage.cpp
    M Source/WebCore/rendering/style/StyleInvalidImage.h
    M Source/WebCore/rendering/style/StyleMultiImage.cpp
    M Source/WebCore/rendering/style/StyleMultiImage.h
    M Source/WebCore/rendering/style/StyleNamedImage.cpp
    M Source/WebCore/rendering/style/StyleNamedImage.h
    M Source/WebCore/rendering/style/StylePaintImage.cpp
    M Source/WebCore/rendering/style/StylePaintImage.h

  Log Message:
  -----------
  StyleImages need to know if they are painting a first-line so they can use the firstLineStyle() instead of style()
https://bugs.webkit.org/show_bug.cgi?id=247127
rdar://101911951

Reviewed by Alan Baradlay.

This allows fixing a case where we incorrectly resolve currentColor at style resolution time.

* Source/WebCore/css/CSSGradientValue.cpp:
(WebCore::computeStyleColor):
* Source/WebCore/rendering/BackgroundPainter.cpp:
(WebCore::BackgroundPainter::paintFillLayer):
* Source/WebCore/rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::image const):
* Source/WebCore/rendering/style/StyleCachedImage.h:
* Source/WebCore/rendering/style/StyleCanvasImage.cpp:
(WebCore::StyleCanvasImage::image const):
* Source/WebCore/rendering/style/StyleCanvasImage.h:
* Source/WebCore/rendering/style/StyleCrossfadeImage.cpp:
(WebCore::StyleCrossfadeImage::image const):
* Source/WebCore/rendering/style/StyleCrossfadeImage.h:
* Source/WebCore/rendering/style/StyleFilterImage.cpp:
(WebCore::StyleFilterImage::image const):
* Source/WebCore/rendering/style/StyleFilterImage.h:
* Source/WebCore/rendering/style/StyleGradientImage.cpp:
(WebCore::StyleGradientImage::image const):
(WebCore::StyleGradientImage::createGradient const):
* Source/WebCore/rendering/style/StyleGradientImage.h:
* Source/WebCore/rendering/style/StyleImage.h:
* Source/WebCore/rendering/style/StyleInvalidImage.cpp:
(WebCore::StyleInvalidImage::image const):
* Source/WebCore/rendering/style/StyleInvalidImage.h:
* Source/WebCore/rendering/style/StyleMultiImage.cpp:
(WebCore::StyleMultiImage::image const):
* Source/WebCore/rendering/style/StyleMultiImage.h:
* Source/WebCore/rendering/style/StyleNamedImage.cpp:
(WebCore::StyleNamedImage::image const):
* Source/WebCore/rendering/style/StyleNamedImage.h:
* Source/WebCore/rendering/style/StylePaintImage.cpp:
(WebCore::StylePaintImage::image const):
* Source/WebCore/rendering/style/StylePaintImage.h:

Canonical link: https://commits.webkit.org/266988@main




More information about the webkit-changes mailing list