[webkit-changes] [WebKit/WebKit] 147e06: [iOS] Adopt ThreadSafeWeakPtr in WebMediaSessionHe...

aestes noreply at github.com
Wed Aug 16 21:26:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 147e066f07349b960743d7d9f950b85c02bfec52
      https://github.com/WebKit/WebKit/commit/147e066f07349b960743d7d9f950b85c02bfec52
  Author: Andy Estes <aestes at apple.com>
  Date:   2023-08-16 (Wed, 16 Aug 2023)

  Changed paths:
    M Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm
    M Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h

  Log Message:
  -----------
  [iOS] Adopt ThreadSafeWeakPtr in WebMediaSessionHelper
https://bugs.webkit.org/show_bug.cgi?id=260205
rdar://113910990

Reviewed by Jean-Yves Avenard.

Adopted ThreadSafeWeakPtr for WebMediaSessionHelper's _callback ivar. Ensured
WebMediaSessionHelper's _monitoringAirPlayRoutes and _startMonitoringAirPlayRoutesPending ivars are
accessed exclusively on the main thread. Fixed some naming and formatting issues, notably renaming
MediaSessionHelperiOS to MediaSessionHelperIOS.

* Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:
(MediaSessionHelper::resetSharedHelper):
(MediaSessionHelperIOS::MediaSessionHelperIOS):
(MediaSessionHelperIOS::providePresentingApplicationPID):
(MediaSessionHelperIOS::startMonitoringWirelessRoutesInternal):
(MediaSessionHelperIOS::stopMonitoringWirelessRoutesInternal):
(MediaSessionHelperIOS::mediaServerConnectionDied):
(MediaSessionHelperIOS::setIsPlayingToAutomotiveHeadUnit):
(MediaSessionHelperIOS::activeAudioRouteDidChange):
(MediaSessionHelperIOS::activeVideoRouteDidChange):
(MediaSessionHelperIOS::externalOutputDeviceAvailableDidChange):
(-[WebMediaSessionHelper initWithCallback:]):
(-[WebMediaSessionHelper hasWirelessTargetsAvailable]):
(-[WebMediaSessionHelper startMonitoringAirPlayRoutes]):
(-[WebMediaSessionHelper applicationWillEnterForeground:]):
(-[WebMediaSessionHelper applicationDidBecomeActive:]):
(-[WebMediaSessionHelper applicationWillResignActive:]):
(-[WebMediaSessionHelper wirelessRoutesAvailableDidChange:]):
(-[WebMediaSessionHelper applicationDidEnterBackground:]):
(-[WebMediaSessionHelper mediaServerConnectionDied:]):
(-[WebMediaSessionHelper carPlayIsConnectedDidChange:]):
(-[WebMediaSessionHelper activeOutputDeviceDidChange:]):
(MediaSessionHelperiOS::MediaSessionHelperiOS): Deleted.
(MediaSessionHelperiOS::~MediaSessionHelperiOS): Deleted.
(MediaSessionHelperiOS::providePresentingApplicationPID): Deleted.
(MediaSessionHelperiOS::startMonitoringWirelessRoutesInternal): Deleted.
(MediaSessionHelperiOS::stopMonitoringWirelessRoutesInternal): Deleted.
(MediaSessionHelperiOS::mediaServerConnectionDied): Deleted.
(MediaSessionHelperiOS::updateCarPlayIsConnected): Deleted.
(MediaSessionHelperiOS::setIsPlayingToAutomotiveHeadUnit): Deleted.
(MediaSessionHelperiOS::activeAudioRouteDidChange): Deleted.
(MediaSessionHelperiOS::activeVideoRouteDidChange): Deleted.
(MediaSessionHelperiOS::externalOutputDeviceAvailableDidChange): Deleted.
(-[WebMediaSessionHelper clearCallback]): Deleted.

Canonical link: https://commits.webkit.org/266985@main




More information about the webkit-changes mailing list