[webkit-changes] [WebKit/WebKit] 46c273: [JSC] Remove stale assertion about OpCall for Phan...

Yusuke Suzuki noreply at github.com
Wed Aug 16 15:04:54 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46c2731264f0dad1744e65916adfc772f81c0ae3
      https://github.com/WebKit/WebKit/commit/46c2731264f0dad1744e65916adfc772f81c0ae3
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-08-16 (Wed, 16 Aug 2023)

  Changed paths:
    A JSTests/stress/ftl-materialize-new-array-buffer.js
    M Source/JavaScriptCore/ftl/FTLOperations.cpp

  Log Message:
  -----------
  [JSC] Remove stale assertion about OpCall for PhantomNewArrayBuffer
https://bugs.webkit.org/show_bug.cgi?id=260302
rdar://113948896

Reviewed by Keith Miller and Justin Michaud.

This assertion is wrong since this bytecode can be op_tail_call etc.
And this assertion offers nothing: we are not doing anything relying on this
assertion's condition. So it is just stale. This patch removes it.

* JSTests/stress/ftl-materialize-new-array-buffer.js: Added.
* Source/JavaScriptCore/ftl/FTLOperations.cpp:
(JSC::FTL::JSC_DEFINE_JIT_OPERATION):

Canonical link: https://commits.webkit.org/266964@main




More information about the webkit-changes mailing list