[webkit-changes] [WebKit/WebKit] 530846: [WPE][GTK] Move `WebKitWebsiteData/memory-pressure...

Vitaly Dyachkov noreply at github.com
Wed Aug 16 08:21:49 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 53084658b468814306b2d1754cfdd3e770808331
      https://github.com/WebKit/WebKit/commit/53084658b468814306b2d1754cfdd3e770808331
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2023-08-16 (Wed, 16 Aug 2023)

  Changed paths:
    A Tools/TestWebKitAPI/Tests/WebKitGLib/TestNetworkProcessMemoryPressure.cpp
    M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp
    M Tools/TestWebKitAPI/glib/CMakeLists.txt

  Log Message:
  -----------
  [WPE][GTK] Move `WebKitWebsiteData/memory-pressure` API test to a separate binary
https://bugs.webkit.org/show_bug.cgi?id=260256

Reviewed by Carlos Garcia Campos.

This test verifies that the network process will be killed if the memory
limit is reached.

It's done by calling `webkit_network_session_set_memory_pressure_settings()`.
The settings passed as an argument are later applied during the creation
of a new network process.

Before 259433 at main a new network process was created for every network
session but now only one network process is created.

Since this test is not the first one in the test suite, the network
process was already created and the memory pressure settings have no effect.

Also, the name of the function is misleading now,
because the memory pressure settings are applied to all sessions.

* Tools/TestWebKitAPI/Tests/WebKitGLib/TestNetworkProcessMemoryPressure.cpp: Added.
(serverCallback):
(MemoryPressureTest::setup):
(MemoryPressureTest::teardown):
(MemoryPressureTest::loadFailedCallback):
(MemoryPressureTest::waitUntilLoadFailed):
(testMemoryPressureSettings):
(beforeAll):
(afterAll):
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(beforeAll):
(MemoryPressureTest::setup): Deleted.
(MemoryPressureTest::teardown): Deleted.
(MemoryPressureTest::loadFailedCallback): Deleted.
(MemoryPressureTest::waitUntilLoadFailed): Deleted.
(testMemoryPressureSettings): Deleted.
* Tools/TestWebKitAPI/glib/CMakeLists.txt:

Canonical link: https://commits.webkit.org/266946@main




More information about the webkit-changes mailing list