[webkit-changes] [WebKit/WebKit] 1d5fbe: visionOS Media Controls: Volume slider has wrong l...

Richard Robinson noreply at github.com
Tue Aug 15 22:06:28 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1d5fbefb714166eebf47d4b06477332bb39b3a32
      https://github.com/WebKit/WebKit/commit/1d5fbefb714166eebf47d4b06477332bb39b3a32
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-08-15 (Tue, 15 Aug 2023)

  Changed paths:
    M Source/WebCore/Modules/modern-media-controls/controls/vision-media-controls.css
    M Source/WebCore/Modules/modern-media-controls/controls/vision-media-controls.js

  Log Message:
  -----------
  visionOS Media Controls: Volume slider has wrong layout in small sizes
https://bugs.webkit.org/show_bug.cgi?id=260130
rdar://113722710

Reviewed by Tim Horton and Tim Nguyen.

The mute button should always be `Bar` when contained in a volume slider.

Drive-by fix: General media controls polish
- Fix bottom bar controls having a weird animation when changing fullscreen size by making the
  transition be constrained only to the slider.
- Increase the size of the volume slider a bit to better match the system, and to make it easier to use.
- Apply the same track thumb style to the volume slider that the time slider uses.

* Source/WebCore/Modules/modern-media-controls/controls/vision-media-controls.css:
(.media-controls.vision.fullscreen .controls-bar.simple-layout .slider.vision.volume,):
(.media-controls.vision:not(.audio) .slider,):
(.media-controls.vision:not(.audio) > .controls-bar.top-right *,):
(.media-controls.vision:not(.audio) > .controls-bar.simple-layout.top-right .fill:after):
(.media-controls.vision:not(.audio) > .bottom.controls-bar .fill:after):
(.media-controls.vision:not(.audio) > .controls-bar.simple-layout.top-right .fill:after,):
(.media-controls.vision:not(.audio) > .controls-bar.simple-layout.top-right .slider:active .fill:after,):
(.media-controls.vision:not(.audio) > .bottom.controls-bar,): Deleted.
(.media-controls.vision:not(.audio) > .bottom.controls-bar *): Deleted.
(.media-controls.vision:not(.audio) > .bottom.controls-bar .slider:active .fill:after): Deleted.
* Source/WebCore/Modules/modern-media-controls/controls/vision-media-controls.js:
(VisionFullscreenMediaControls.prototype._performBottomBarLayout):
(VisionFullscreenMediaControls):

Canonical link: https://commits.webkit.org/266939@main




More information about the webkit-changes mailing list