[webkit-changes] [WebKit/WebKit] cf3b8b: Resizing video on YouTube can result in aliasing

mwyrzykowski noreply at github.com
Tue Aug 15 18:19:44 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf3b8b67645c5fb573accdf3076b62ae790d357b
      https://github.com/WebKit/WebKit/commit/cf3b8b67645c5fb573accdf3076b62ae790d357b
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-08-15 (Tue, 15 Aug 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderVideo.cpp
    M Source/WebCore/rendering/RenderVideo.h

  Log Message:
  -----------
  Resizing video on YouTube can result in aliasing
https://bugs.webkit.org/show_bug.cgi?id=259171
<radar://112172798>

Reviewed by Tim Horton.

Undo the revert of 266284 at main but pass the correct size which
is videoBox().size() as opposed to contentSize(), so that videos
playing in fullscreen element which are within one point of the window
size take up the entire window size.

The latter caused a regression on macOS and iOS for letter boxed
videos or videos which did not consume the entire contentSize.

* Source/WebCore/rendering/RenderVideo.cpp:
(WebCore::RenderVideo::videoBox const):
(WebCore::RenderVideo::inElementOrVideoFullscree const):
(WebCore::RenderVideo::updatePlayer):
* Source/WebCore/rendering/RenderVideo.h:

Canonical link: https://commits.webkit.org/266933@main




More information about the webkit-changes mailing list