[webkit-changes] [WebKit/WebKit] 7cada1: Fix and extend in-place interpreter OSR

Daniel Liu noreply at github.com
Tue Aug 15 15:11:06 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7cada1627710e0b199af744fcaa0feaa53d8b330
      https://github.com/WebKit/WebKit/commit/7cada1627710e0b199af744fcaa0feaa53d8b330
  Author: Daniel Liu <danlliu at umich.edu>
  Date:   2023-08-15 (Tue, 15 Aug 2023)

  Changed paths:
    M Source/JavaScriptCore/llint/InPlaceInterpreter.asm
    M Source/JavaScriptCore/runtime/OptionsList.h
    M Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp
    M Source/JavaScriptCore/wasm/WasmSlowPaths.cpp
    M Source/JavaScriptCore/wasm/WasmSlowPaths.h

  Log Message:
  -----------
  Fix and extend in-place interpreter OSR
https://bugs.webkit.org/show_bug.cgi?id=260212
rdar://113919529

Reviewed by Yusuke Suzuki.

Fixed a bug where loop OSR did not trigger in the in-place interpreter after the first iteration because the PC was set to the instruction after the loop, rather than the loop itself. This resolves quicksort-wasm in JS2 performance issues locally.
Added epilogue OSR implementation to the in-place interpreter.

* Source/JavaScriptCore/llint/InPlaceInterpreter.asm:
* Source/JavaScriptCore/runtime/OptionsList.h:
* Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp:
(JSC::Wasm::IPIntGenerator::addLoop):
* Source/JavaScriptCore/wasm/WasmSlowPaths.cpp:
(JSC::LLInt::WASM_IPINT_EXTERN_CPP_DECL):
* Source/JavaScriptCore/wasm/WasmSlowPaths.h:

Canonical link: https://commits.webkit.org/266927@main




More information about the webkit-changes mailing list