[webkit-changes] [WebKit/WebKit] fed29d: Move and expose various helper functions into Inli...

Commit Queue noreply at github.com
Tue Aug 15 12:21:29 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fed29deb55177e7ea9a07ca6ef35bdddcf5fa7e8
      https://github.com/WebKit/WebKit/commit/fed29deb55177e7ea9a07ca6ef35bdddcf5fa7e8
  Author: David Choi <david_choi5 at apple.com>
  Date:   2023-08-15 (Tue, 15 Aug 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h

  Log Message:
  -----------
  Move and expose various helper functions into InlineFormattingGeometry
https://bugs.webkit.org/show_bug.cgi?id=259908
rdar://113533527

Reviewed by Alan Baradlay.

The following functions need to be moved and be accessible via
InlineFormattingGeometry for upcoming work on text-wrap: balance.
 - leadingInlineItemPositionForNextLine (static function in InlineFormattingContext.cpp)
 - LineBuilder::inlineItemWidth
 - LineBuilder::nextWrapOpportunity

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):
(WebCore::Layout::leadingInlineItemPositionForNextLine): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::InlineFormattingGeometry::leadingInlineItemPositionForNextLine):
(WebCore::Layout::InlineFormattingGeometry::inlineItemWidth const):
(WebCore::Layout::endsWithSoftWrapOpportunity):
(WebCore::Layout::isAtSoftWrapOpportunity):
(WebCore::Layout::InlineFormattingGeometry::nextWrapOpportunity):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::candidateContentForLine):
(WebCore::Layout::LineBuilder::rebuildLineWithInlineContent):
(WebCore::Layout::endsWithSoftWrapOpportunity): Deleted.
(WebCore::Layout::isAtSoftWrapOpportunity): Deleted.
(WebCore::Layout::LineBuilder::inlineItemWidth const): Deleted.
(WebCore::Layout::LineBuilder::nextWrapOpportunity const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:

Canonical link: https://commits.webkit.org/266922@main




More information about the webkit-changes mailing list