[webkit-changes] [WebKit/WebKit] 28bfc9: AX: Fix multiple-label-input test in ITM mode

Joshua Hoffman noreply at github.com
Tue Aug 15 11:00:40 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 28bfc960f4a128c6a21f54c9a950edcb5b09f544
      https://github.com/WebKit/WebKit/commit/28bfc960f4a128c6a21f54c9a950edcb5b09f544
  Author: hoffmanjoshua <jhoffman23 at apple.com>
  Date:   2023-08-15 (Tue, 15 Aug 2023)

  Changed paths:
    M LayoutTests/accessibility-isolated-tree/TestExpectations
    M LayoutTests/accessibility/multiple-label-input-expected.txt
    M LayoutTests/accessibility/multiple-label-input.html
    M LayoutTests/platform/glib/accessibility/multiple-label-input-expected.txt
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp

  Log Message:
  -----------
  AX: Fix multiple-label-input test in ITM mode
https://bugs.webkit.org/show_bug.cgi?id=260174
rdar://113872525

Reviewed by Andres Gonzalez.

This patch resolves an issue where innerHTML and innerText changes to labels were not updating their corresponding input element's AX title.

* LayoutTests/accessibility-isolated-tree/TestExpectations
* LayoutTests/platform/glib/accessibility/multiple-label-input-expected.txt

* LayoutTests/accessibility/multiple-label-input.html
* LayoutTests/accessibility/multiple-label-input-expected.txt:

Added check for using innerHTML—only checked for innerText functionality previously.

* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::updateIsolatedTree):

If static text changes and its parent is a <label>, update the corresponding control.

* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeAndDependentProperties):

Check if a label is being modified (using innerText). If it is, update the corresponding control.

Canonical link: https://commits.webkit.org/266919@main




More information about the webkit-changes mailing list