[webkit-changes] [WebKit/WebKit] 8e9f2e: ServiceWorkerRegistration data is not deleted corr...

Sihui noreply at github.com
Mon Aug 14 15:56:56 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e9f2eb04c2e6dcb35850e785b6626545838af95
      https://github.com/WebKit/WebKit/commit/8e9f2eb04c2e6dcb35850e785b6626545838af95
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-08-14 (Mon, 14 Aug 2023)

  Changed paths:
    M Source/WebCore/workers/service/server/SWRegistrationDatabase.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm

  Log Message:
  -----------
  ServiceWorkerRegistration data is not deleted correctly
https://bugs.webkit.org/show_bug.cgi?id=260163
rdar://112092827

Reviewed by Brent Fulgham.

bindText() returns error code and 0 (SQLITE_OK) means the operation succeeds, so updateRegistrations should not return
early.

API Test: WKWebsiteDataStore.RemoveServiceWorkerDataByOrigin

* Source/WebCore/workers/service/server/SWRegistrationDatabase.cpp:
(WebCore::SWRegistrationDatabase::updateRegistrations):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

Canonical link: https://commits.webkit.org/266882@main




More information about the webkit-changes mailing list