[webkit-changes] [WebKit/WebKit] 79c970: Include -fsanitize flags with OTHER_TAPI_FLAGS dur...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 79c970402bf97b82723fe5e59f5a6e00e38dd4c6
      https://github.com/WebKit/WebKit/commit/79c970402bf97b82723fe5e59f5a6e00e38dd4c6
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2023-08-14 (Mon, 14 Aug 2023)

  Changed paths:
    M Configurations/CommonBase.xcconfig
    M Configurations/Sanitizers.xcconfig
    M Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig
    M Source/WebKit/Configurations/Base.xcconfig
    M Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig

  Log Message:
  -----------
  Include -fsanitize flags with OTHER_TAPI_FLAGS during builds
https://bugs.webkit.org/show_bug.cgi?id=260119
<rdar://113800841>

Reviewed by Alex Christensen.

Although there are currently no build failures with TAPI and a Sanitizer
enabled, this is a correctness fix to prevent such issues by passing the
proper -fsanitize flags during the InstallAPI (TAPI) build phase.

* Configurations/CommonBase.xcconfig:
(WK_COMMON_OTHER_TAPI_FLAGS): Add.
- Extract common flags from OTHER_TAPI_FLAGS in project xcconfig files.
- Add $(WK_SANITIZER_OTHER_TAPI_FLAGS) from Sanitizers.xcconfig.
(OTHER_TAPI_FLAGS):
- Add $(WK_COMMON_OTHER_TAPI_FLAGS) in OTHER_TAPI_FLAGS.

* Configurations/Sanitizers.xcconfig:
(WK_SANITIZER_OTHER_TAPI_FLAGS): Add.
- Includes variables below based on whether various sanitizers are
  enabled during the build.
(WK_SANITIZER_OTHER_TAPI_FLAGS_ASAN_YES): Add.
(WK_SANITIZER_OTHER_TAPI_FLAGS_LIBFUZZER_YES): Add.
(WK_SANITIZER_OTHER_TAPI_FLAGS_TSAN_YES): Add.
(WK_SANITIZER_OTHER_TAPI_FLAGS_UBSAN_YES): Add.
- Sanitizer-specific flags for use with OTHER_TAPI_FLAGS.

* Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
(OTHER_TAPI_FLAGS):
* Source/WebKit/Configurations/Base.xcconfig:
(OTHER_TAPI_FLAGS):
* Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:
(OTHER_TAPI_FLAGS):
- Add $(inherited) to OTHER_TAPI_FLAGS so that the definition in
  Configurations/CommonBase.xcconfig is included.

Canonical link: https://commits.webkit.org/266867@main