[webkit-changes] [WebKit/WebKit] 8222cb: [visionOS] WKContentView doesn't relinquish first ...

Ryan Fuller noreply at github.com
Mon Aug 14 07:30:31 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8222cb10b1d003da26267b6132e73e1a1df636fd
      https://github.com/WebKit/WebKit/commit/8222cb10b1d003da26267b6132e73e1a1df636fd
  Author: Ryan Fuller <ryanfuller at apple.com>
  Date:   2023-08-14 (Mon, 14 Aug 2023)

  Changed paths:
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  [visionOS] WKContentView doesn't relinquish first responder after tapping Safari unified field
https://bugs.webkit.org/show_bug.cgi?id=260060
rdar://113732040

Reviewed by Wenson Hsieh.

The keyboard request dismissal can happen *after* the firstResponder chain
is affected by the dismissal and in fact this does happen on visionOS. By
also checking _isEditable we ensure that even if the firstResponder is the
content view but was not before the dismissal, we don't incorrectly set the
keyboard lock to true (blocking the next attempted resignation), as
_isEditable is not yet true in this case.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _keyboardDidRequestDismissal:]):
Require the content view is firstResponder AND editable to block the next
firstResponder resignation attempt.

Canonical link: https://commits.webkit.org/266863@main




More information about the webkit-changes mailing list