[webkit-changes] [WebKit/WebKit] 5e5018: WebGL sends nonstandard webglcontextchanged event

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5e5018b1d23d63e034f6ba8c0551752b261e521e
      https://github.com/WebKit/WebKit/commit/5e5018b1d23d63e034f6ba8c0551752b261e521e
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-08-14 (Mon, 14 Aug 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    R LayoutTests/fast/canvas/webgl/context-update-on-display-configuration-expected.txt
    R LayoutTests/fast/canvas/webgl/context-update-on-display-configuration.html
    R LayoutTests/fast/canvas/webgl/webglcontextchangedevent-expected.txt
    R LayoutTests/fast/canvas/webgl/webglcontextchangedevent.html
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac-wk2/TestExpectations
    M LayoutTests/platform/wincairo/TestExpectations
    M Source/WebCore/dom/EventNames.h
    M Source/WebCore/html/HTMLCanvasElement.cpp
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.h
    M Source/WebCore/platform/graphics/GraphicsContextGL.cpp
    M Source/WebCore/platform/graphics/GraphicsContextGL.h
    M Source/WebCore/platform/graphics/GraphicsContextGLEnums.h
    M Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp
    M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl
    M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp
    M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h
    M Source/WebKit/Headers.cmake
    M Source/WebKit/Modules/OSX_Private.modulemap
    M Source/WebKit/Modules/iOS_Private.modulemap
    M Source/WebKit/Shared/WebCoreArgumentCoders.h
    M Source/WebKit/Sources.txt
    R Source/WebKit/UIProcess/API/C/WKMockDisplay.cpp
    R Source/WebKit/UIProcess/API/C/WKMockDisplay.h
    M Source/WebKit/UIProcess/WebProcessPool.cpp
    M Source/WebKit/UIProcess/WebProcessPool.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h
    M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.messages.in
    M Tools/TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
    M Tools/WebKitTestRunner/TestController.cpp
    M Tools/WebKitTestRunner/TestController.h
    M Tools/WebKitTestRunner/TestInvocation.cpp

  Log Message:
  -----------
  WebGL sends nonstandard webglcontextchanged event
https://bugs.webkit.org/show_bug.cgi?id=260018
rdar://113677584

Reviewed by Dan Glastonbury.

Remove the code to send the webglcontextchanged event.

The event was not in the specification. It was only dispatched for
OpenGL based dual-GPU machines, e.g. on specific machines on Big Sur.

Remove the code to test the delivering webglcontextchanged.

Note: preserve the code for changing WebGL contexts to current GPU.
So for example, if user plugs external monitor to such a computer,
the WebGL contexts will still migrate to dGPU. This is just not
observable through webglcontextchanged. Naturally, the intention is that
this is not observable in any way other than performance difference.

* LayoutTests/fast/canvas/webgl/context-update-on-display-configuration-expected.txt: Removed.
* LayoutTests/fast/canvas/webgl/context-update-on-display-configuration.html: Removed.
* LayoutTests/fast/canvas/webgl/webglcontextchangedevent-expected.txt: Removed.
* LayoutTests/fast/canvas/webgl/webglcontextchangedevent.html: Removed.
* Source/WebCore/dom/EventNames.h:
* Source/WebCore/html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::virtualHasPendingActivity const):
(WebCore::HTMLCanvasElement::eventListenersDidChange):
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::dispatchContextChangedNotification): Deleted.
* Source/WebCore/html/canvas/WebGLRenderingContextBase.h:
* Source/WebCore/platform/graphics/GraphicsContextGL.cpp:
(WebCore::GraphicsContextGL::dispatchContextChangedNotification): Deleted.
* Source/WebCore/platform/graphics/GraphicsContextGL.h:
* Source/WebCore/platform/graphics/GraphicsContextGLEnums.h:
* Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::simulateEventForTesting):
* Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
(WebCore::GraphicsContextGLCocoa::updateContextOnDisplayReconfiguration):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::simulateEventForWebGLContext):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
(WebKit::RemoteGraphicsContextGL::simulateEventForTesting):
(WebKit::RemoteGraphicsContextGL::dispatchContextChangedNotification): Deleted.
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h:
* Source/WebKit/Headers.cmake:
* Source/WebKit/Modules/OSX_Private.modulemap:
* Source/WebKit/Modules/iOS_Private.modulemap:
* Source/WebKit/Shared/WebCoreArgumentCoders.h:
* Source/WebKit/Sources.txt:
* Source/WebKit/UIProcess/API/C/WKMockDisplay.cpp: Removed.
* Source/WebKit/UIProcess/API/C/WKMockDisplay.h: Removed.
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::sendDisplayConfigurationChangedMessageForTesting): Deleted.
* Source/WebKit/UIProcess/WebProcessPool.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::handleMessageToRemovedDestination):
(WebKit::RemoteGraphicsContextGLProxy::wasChanged): Deleted.
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.messages.in:
* Tools/TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::sendDisplayConfigurationChangedMessageForTesting): Deleted.
* Tools/WebKitTestRunner/TestController.h:
* Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

Canonical link: https://commits.webkit.org/266861@main