[webkit-changes] [WebKit/WebKit] 0fcecf: [IntersectionObserver] Fix some edge cases in pars...

Ahmad Saleem noreply at github.com
Sun Aug 13 13:37:10 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0fcecf40e3a1d5863c5161302409208958ef1821
      https://github.com/WebKit/WebKit/commit/0fcecf40e3a1d5863c5161302409208958ef1821
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-08-13 (Sun, 13 Aug 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/observer-attributes-expected.txt
    M Source/WebCore/page/IntersectionObserver.cpp

  Log Message:
  -----------
  [IntersectionObserver] Fix some edge cases in parsing options

https://bugs.webkit.org/show_bug.cgi?id=260126

Reviewed by Ryosuke Niwa.

This patch aligns WebKit with Blink / Chromium.

Merge: https://chromium-review.googlesource.com/c/chromium/src/+/2388706

This patch fixes some edge cases in InterssectionObserver by doing two things:
- For 'rootMargine', make 'token' to consume whitespace
- For 'thresholds', add new case in case 'empty' to return '0'

* Source/WebCore/page/IntersectionObserver.cpp:
(parseRootMargin):
(IntersectionObserver::create):
* LayoutTests/imported/w3c/web-platform-tests/intersection-observer/observer-attributes-expected.txt: Rebaselined

Canonical link: https://commits.webkit.org/266856@main




More information about the webkit-changes mailing list