[webkit-changes] [WebKit/WebKit] 715601: [IFC] Turn LineLayoutResult into a cacheable object
Alan Baradlay
noreply at github.com
Sun Aug 13 07:08:22 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 715601cff4afd09fb336935a0dfe6a7c2680d299
https://github.com/WebKit/WebKit/commit/715601cff4afd09fb336935a0dfe6a7c2680d299
Author: Alan Baradlay <zalan at apple.com>
Date: 2023-08-13 (Sun, 13 Aug 2023)
Changed paths:
M Source/WebCore/layout/formattingContexts/inline/AbstractLineBuilder.h
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.h
M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLine.h
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h
M Source/WebCore/layout/formattingContexts/inline/TextOnlyLineBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/TextOnlyLineBuilder.h
Log Message:
-----------
[IFC] Turn LineLayoutResult into a cacheable object
https://bugs.webkit.org/show_bug.cgi?id=260045
Reviewed by Antti Koivisto.
This is in preparation for sharing the result of line building between min/max and inline layout codepaths.
(Make some function static so that they don't accidentally access to moved out m_line)
* Source/WebCore/layout/formattingContexts/inline/AbstractLineBuilder.h:
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::InlineFormattingGeometry::contentLeftAfterLastLine const):
(WebCore::Layout::InlineFormattingGeometry::horizontalAlignmentOffset):
(WebCore::Layout::InlineFormattingGeometry::horizontalAlignmentOffset const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::close):
* Source/WebCore/layout/formattingContexts/inline/InlineLine.h:
(WebCore::Layout::Line::contentNeedsBidiReordering const):
(WebCore::Layout::Line::hangingTrailingContentWidth const):
(WebCore::Layout::Line::isHangingTrailingContentWhitespace const):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::computedVisualOrder):
(WebCore::Layout::horizontalAlignmentOffset):
(WebCore::Layout::isLastLineWithInlineContent):
(WebCore::Layout::inlineBaseDirectionForLineContent):
(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::placeInlineAndFloatContent):
(WebCore::Layout::LineBuilder::isLastLineWithInlineContent const): Deleted.
(WebCore::Layout::LineBuilder::inlineBaseDirectionForLineContent const): Deleted.
(WebCore::Layout::LineBuilder::horizontalAlignmentOffset const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:
* Source/WebCore/layout/formattingContexts/inline/TextOnlyLineBuilder.cpp:
(WebCore::Layout::horizontalAlignmentOffset):
(WebCore::Layout::TextOnlyLineBuilder::layoutInlineContent):
(WebCore::Layout::TextOnlyLineBuilder::horizontalAlignmentOffset const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/TextOnlyLineBuilder.h:
Canonical link: https://commits.webkit.org/266853@main
More information about the webkit-changes
mailing list