[webkit-changes] [WebKit/WebKit] 5df588: Web Inspector: Incremental in FilterBar

Frances Cornwall noreply at github.com
Thu Aug 10 17:27:54 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5df588e41bbde364c506774ce20012536c801b49
      https://github.com/WebKit/WebKit/commit/5df588e41bbde364c506774ce20012536c801b49
  Author: Frances Cornwall <frances_c at cox.net>
  Date:   2023-08-10 (Thu, 10 Aug 2023)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Views/FilterBar.js

  Log Message:
  -----------
  Web Inspector: Incremental in FilterBar
https://bugs.webkit.org/show_bug.cgi?id=260043

Reviewed by Devin Rousso.

The filter bar was not working correctly due to "search" being removed.

Replace incremental with throttler. Delete incremental getter and setter.

Switch eventlistener to "input" instead of "search".

Rename "_handleFilterSearched" to "_handleFilterInput"

Delete unused "_handleFilterInputEvent"

* Source/WebInspectorUI/UserInterface/Views/FilterBar.js:
(WI.FilterBar.prototype.set filters):
(WI.FilterBar.prototype.addFilterBarButton):
(WI.FilterBar.prototype._handleFilterButtonToggled):
(WI.FilterBar.prototype._handleFilterInputEvent):
(WI.FilterBar.prototype.get incremental): Deleted.
(WI.FilterBar.prototype.set incremental): Deleted.
(WI.FilterBar.prototype._handleFilterChanged): Deleted.
(WI.FilterBar.prototype._handleFilterInputEvent): Deleted.

Canonical link: https://commits.webkit.org/266802@main




More information about the webkit-changes mailing list