[webkit-changes] [WebKit/WebKit] c2e669: run-benchmarks occasionally fails to download Spee...

[hysu]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2e669da7d0077db7d0ec1eb14b33788effe9354
      https://github.com/WebKit/WebKit/commit/c2e669da7d0077db7d0ec1eb14b33788effe9354
  Author: Hysu Xiong <hysu at apple.com>
  Date:   2023-08-10 (Thu, 10 Aug 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py

  Log Message:
  -----------
  run-benchmarks occasionally fails to download Speedometer3
https://bugs.webkit.org/show_bug.cgi?id=260044
rdar://problem/113717485

Reviewed by Jonathan Bedard.

Occasionally, urllib will fail to find its CAcert (or discover that it is invalid); our other benchmarks use requests to pull from Github, which uses certifi's CAcert in the background. This is why we haven't hit this issue much in the past.

This patch changes urlretrieve to requests.get in order to use certifi's CAcert under the hood. It also adds chunked downloading - which will help if we ever need to download large file archives for benchmarks.

* Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
(BenchmarkBuilder._fetch_remote_archive):

Canonical link: https://commits.webkit.org/266796@main