[webkit-changes] [WebKit/WebKit] 6f0a9e: [css-writing-modes] Disable text-combine-upright w...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6f0a9e880a3f725d85f1316eb588eb3a80c65700
      https://github.com/WebKit/WebKit/commit/6f0a9e880a3f725d85f1316eb588eb3a80c65700
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-08-10 (Thu, 10 Aug 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/rendering/RenderCombineText.cpp

  Log Message:
  -----------
  [css-writing-modes] Disable text-combine-upright with sideways writing modes
https://bugs.webkit.org/show_bug.cgi?id=260034
rdar://113703767

Reviewed by Sammy Gill.

text-combine-upright should only work when using vertical typographic modes, not horizontal.

Check for the typographic mode instead of the writing mode, to exclude sideways writing mode (which uses the horizontal typographic mode).

* LayoutTests/TestExpectations:
* Source/WebCore/rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::combineTextIfNeeded):

Canonical link: https://commits.webkit.org/266792@main