[webkit-changes] [WebKit/WebKit] a36c08: Missing value default for `animateTransform` 'type...

Ahmad Saleem noreply at github.com
Thu Aug 10 04:27:36 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a36c08c207956760be4d478f9dc86e3938394cb4
      https://github.com/WebKit/WebKit/commit/a36c08c207956760be4d478f9dc86e3938394cb4
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-08-10 (Thu, 10 Aug 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/svg/animations/scripted/animatetransform-type-missing-value-default-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/svg/animations/scripted/animatetransform-type-missing-value-default.html
    M Source/WebCore/svg/SVGAnimateTransformElement.cpp

  Log Message:
  -----------
  Missing value default for `animateTransform` 'type' is 'translate'

https://bugs.webkit.org/show_bug.cgi?id=259885

Reviewed by Simon Fraser.

This patch aligns WebKit with Gecko / Firefox, Blink / Chromium and Web-Spec [1].

[1] https://www.w3.org/TR/SVG11/animate.html#AnimateTransformElementTypeAttribute

"If the attribute is not specified, then the effect is as if a value of 'translate'
were specified".

This PR changes default value from 'SVG_TRANSFORM_UNKNOWN' to
'SVG_TRANSFORM_TRANSLATE'.

* Source/WebCore/svg/SVGAnimateTransformElement.cpp: As above
* LayoutTests/imported/w3c/web-platform-tests/svg/animations/scripted/animatetransform-type-missing-value-default.html: Add Test Case
* LayoutTests/imported/w3c/web-platform-tests/svg/animations/scr…/animatetransform-type-missing-value-default-expected.txt: Add Test Case Expectation

Canonical link: https://commits.webkit.org/266758@main




More information about the webkit-changes mailing list