[webkit-changes] [WebKit/WebKit] 69d07a: When selecting Live Text in Safari on iOS, the sel...

Richard Robinson noreply at github.com
Wed Aug 9 21:47:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 69d07a6b99c8a8d16460bcbb220cb68c63758479
      https://github.com/WebKit/WebKit/commit/69d07a6b99c8a8d16460bcbb220cb68c63758479
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-08-09 (Wed, 09 Aug 2023)

  Changed paths:
    M LayoutTests/resources/ui-helper.js
    M Source/WebKit/UIProcess/ios/WKTextSelectionRect.mm
    M Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl
    M Tools/TestRunnerShared/UIScriptContext/UIScriptController.h
    M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h
    M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm

  Log Message:
  -----------
  When selecting Live Text in Safari on iOS, the selection handles move away from the selection when zooming
https://bugs.webkit.org/show_bug.cgi?id=259964
rdar://111793617

Reviewed by Wenson Hsieh.

UIKit now scales the selection handles when zooming and updates their position accordingly.
Since WebKit is also scaling them ourselves, this results in a position that's offset from the
selection proportional to the zoom amount.

Fix by no longer scaling the selection handles in WebKit.

* LayoutTests/resources/ui-helper.js:
(window.UIHelper.getSelectionEndGrabberViewShapePathDescription.return.new.Promise.):
(window.UIHelper.getSelectionEndGrabberViewShapePathDescription.return.new.Promise):
(window.UIHelper.getSelectionEndGrabberViewShapePathDescription):
* Source/WebKit/UIProcess/ios/WKTextSelectionRect.mm:
(-[WKTextSelectionRect _customHandleInfo]):
* Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* Tools/TestRunnerShared/UIScriptContext/UIScriptController.h:
(WTR::UIScriptController::selectionEndGrabberViewShapePathDescription const):
* Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h:
* Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptControllerIOS::selectionEndGrabberViewShapePathDescription const):

Canonical link: https://commits.webkit.org/266753@main




More information about the webkit-changes mailing list