[webkit-changes] [WebKit/WebKit] 66b9bc: Signals.cpp implementation for Windows

Ian noreply at github.com
Tue Aug 8 22:39:50 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 66b9bc907a2e984b5f6c15729edad082f0a59a83
      https://github.com/WebKit/WebKit/commit/66b9bc907a2e984b5f6c15729edad082f0a59a83
  Author: Ian Grunert <ian.grunert at gmail.com>
  Date:   2023-08-08 (Tue, 08 Aug 2023)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp
    M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.h
    M Source/WTF/wtf/PlatformJSCOnly.cmake
    M Source/WTF/wtf/PlatformWin.cmake
    M Source/WTF/wtf/WTFConfig.h
    M Source/WTF/wtf/threads/Signals.cpp
    M Source/WTF/wtf/threads/Signals.h
    A Source/WTF/wtf/win/SignalsWin.cpp
    M Tools/TestWebKitAPI/CMakeLists.txt
    M Tools/TestWebKitAPI/Tests/WTF/Signals.cpp

  Log Message:
  -----------
  Signals.cpp implementation for Windows
https://bugs.webkit.org/show_bug.cgi?id=259108

Reviewed by Yusuke Suzuki.

Signals is implemented using a VectoredExceptionHandler on Windows, so
we cannot support all the Signal types as the other OS's. We need
support for AccessFault, which is used for WASM memory.

Test: Tools/TestWebKitAPI/Tests/WTF/Signals.cpp

* Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp:
* Source/JavaScriptCore/wasm/WasmFaultSignalHandler.h:
* Source/WTF/wtf/PlatformJSCOnly.cmake:
* Source/WTF/wtf/PlatformWin.cmake:
* Source/WTF/wtf/WTFConfig.h:
* Source/WTF/wtf/threads/Signals.cpp:
(WTF::toSystemSignal):
(WTF::fromSystemSignal):
* Source/WTF/wtf/threads/Signals.h:
(WTF::toSystemSignal): Deleted.
(WTF::fromSystemSignal): Deleted.
* Source/WTF/wtf/win/SignalsWin.cpp: Added.
(WTF::SignalHandlers::add):
(WTF::SignalHandlers::forEachHandler const):
(WTF::fromSystemException):
(WTF::vectoredHandler):
(WTF::addSignalHandler):
(WTF::activateSignalHandlersFor):
(WTF::SignalHandlers::initialize):
* Tools/TestWebKitAPI/CMakeLists.txt:
* Tools/TestWebKitAPI/Tests/WTF/Signals.cpp:
(TEST):

Canonical link: https://commits.webkit.org/266716@main




More information about the webkit-changes mailing list