[webkit-changes] [WebKit/WebKit] e9d28c: makeOpportunisticTaskDeferralScopeIfPossible has a...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e9d28ce63fa4b7ad9bfd34c955c661d10e3bd03c
      https://github.com/WebKit/WebKit/commit/e9d28ce63fa4b7ad9bfd34c955c661d10e3bd03c
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-08-08 (Tue, 08 Aug 2023)

  Changed paths:
    M Source/WebCore/page/DOMTimer.cpp
    M Source/WebCore/page/DOMTimer.h
    M Source/WebCore/page/Page.h

  Log Message:
  -----------
  makeOpportunisticTaskDeferralScopeIfPossible has a wrong early exit logic
https://bugs.webkit.org/show_bug.cgi?id=259857

Reviewed by Mark Lam, Yusuke Suzuki and Wenson Hsieh.

We want to defer opportunistic task whenever we have a timer firing in the next 1ms,
not whenever we have a timer firing in 1ms or later. But changing the condition to
that causes ~1% Speedometer 2.1 regression in macOS Sonoma so simply delete
OpportunisticTaskDeferralScope entirely out of DOMTimer. This seems perf neutral on
macOS Sonoma and around ~0.7% Speedometer 2.1 progression in macOS Ventura.

* Source/WebCore/page/DOMTimer.cpp:
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::removeById):
(WebCore::DOMTimer::fired):
(WebCore::DOMTimer::didStop):
(WebCore::DOMTimer::makeOpportunisticTaskDeferralScopeIfPossible): Deleted.
(WebCore::DOMTimer::clearOpportunisticTaskDeferralScopeIfPossible): Deleted.
* Source/WebCore/page/DOMTimer.h:
* Source/WebCore/page/Page.h:

Canonical link: https://commits.webkit.org/266680@main