[webkit-changes] [WebKit/WebKit] 1697dc: [visionOS] Audio is still heard after closing Safari

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1697dcdd99ecc3c35564570f38210710fe982868
      https://github.com/WebKit/WebKit/commit/1697dcdd99ecc3c35564570f38210710fe982868
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-08-07 (Mon, 07 Aug 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm

  Log Message:
  -----------
  [visionOS] Audio is still heard after closing Safari
https://bugs.webkit.org/show_bug.cgi?id=259909
rdar://112627755

Reviewed by Eric Carlson.

The root cause of this issue is the same as 266665 at main. See that change for
additional details.

However, 266665 at main is an incomplete fix, as `AVSampleBufferRenderSynchronizer`'s
rate may still be non-zero, while the timebase's rate is changed to zero. In
this case `m_playing` continues to remain true, and playback gets resumed
following the interruption.

To fix, set `m_playing` based on the timebase rate, which is the most accurate
information available. AVSBRS's rate will eventually get set to zero too.

* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::effectiveRateChanged):

Canonical link: https://commits.webkit.org/266675@main