[webkit-changes] [WebKit/WebKit] 41847f: [JSC] IntrinsicGetter AccessCase should not use Eq...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 41847fe79586f5031cd0af2b87858561a0c46f63
      https://github.com/WebKit/WebKit/commit/41847fe79586f5031cd0af2b87858561a0c46f63
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-08-07 (Mon, 07 Aug 2023)

  Changed paths:
    M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp
    M Source/JavaScriptCore/bytecode/ObjectPropertyConditionSet.cpp
    M Source/JavaScriptCore/bytecode/ObjectPropertyConditionSet.h
    M Source/JavaScriptCore/bytecode/Repatch.cpp

  Log Message:
  -----------
  [JSC] IntrinsicGetter AccessCase should not use Equivalent condition
https://bugs.webkit.org/show_bug.cgi?id=259841
rdar://113416758

Reviewed by Keith Miller.

265594 at main leveraged Equivalent condition in AccessCase, but this is wrong.
DFG cannot use Equivalent condition for AccessCase (see planLoad, ComplexGetByStatus etc.),
and breaking a key invariant / heuristics for DFG.

This patch reverts 265594 at main and fixes the original issue in different way.
Instead of using Equivalent condition, we just check getter in AccessCase.

* Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:
(JSC::InlineCacheCompiler::generateImpl):
* Source/JavaScriptCore/bytecode/ObjectPropertyConditionSet.cpp:
(JSC::generateConditionsForPrototypePropertyHit):
* Source/JavaScriptCore/bytecode/ObjectPropertyConditionSet.h:
* Source/JavaScriptCore/bytecode/Repatch.cpp:
(JSC::tryCacheGetBy):

Canonical link: https://commits.webkit.org/266659@main