[webkit-changes] [WebKit/WebKit] 5e15a2: Remove unnecessary includes from WebPage.h

Alex Christensen noreply at github.com
Sat Aug 5 12:36:34 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5e15a2d485f5fe844c29c6506a1582ca8b2bd0cc
      https://github.com/WebKit/WebKit/commit/5e15a2d485f5fe844c29c6506a1582ca8b2bd0cc
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-08-05 (Sat, 05 Aug 2023)

  Changed paths:
    M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/cocoa/TextTrackRepresentationCocoa.mm

  Log Message:
  -----------
  Remove unnecessary includes from WebPage.h
https://bugs.webkit.org/show_bug.cgi?id=259790
rdar://113352476

Reviewed by Wenson Hsieh.

I moved the use of IPC::SendSyncOption::MaintainOrderingWithAsyncMessages to the callers of
sendSyncWithDelayedReply so we don't need to include Connection.h.

I removed the initializer of m_userInterfaceLayoutDirection because it is manually initialized
in the one and only constructor of WebPage so we don't need to include UserInterfaceLayoutDirection.h.

While I was cleaning up WebPage.h I made m_activeColorChooser a WeakPtr rather than a raw pointer.

* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
(WebKit::WebChromeClient::print):
(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota):
* Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::activeColorChooser const):
(WebKit::WebPage::requestDOMPasteAccess):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::drawPagesForPrintingDuringDOMPrintOperation):
(WebKit::WebPage::activeColorChooser const): Deleted.
* Source/WebKit/WebProcess/cocoa/TextTrackRepresentationCocoa.mm:

Canonical link: https://commits.webkit.org/266617@main




More information about the webkit-changes mailing list