[webkit-changes] [WebKit/WebKit] 40e0cb: Make sure end printing is handled before PrintFrame

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 40e0cbc86345b7e968381443f74fd10b65759b43
      https://github.com/WebKit/WebKit/commit/40e0cbc86345b7e968381443f74fd10b65759b43
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-08-04 (Fri, 04 Aug 2023)

  Changed paths:
    A LayoutTests/fast/media/print-video-crash-expected.txt
    A LayoutTests/fast/media/print-video-crash.html
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
    M Tools/WebKitTestRunner/TestController.cpp

  Log Message:
  -----------
  Make sure end printing is handled before PrintFrame
https://bugs.webkit.org/show_bug.cgi?id=237291

Reviewed by Chris Dumez.

To ensure end printing is handled (and layer tree is unfrozen)
introduce a completion handler on EndPrinting and tie its completion
to the completion handler in WebPageProxy::printFrame.

Also do not call endPrinting from TestController.cpp since
WebPageProxy::printFrame takes care of that.

* LayoutTests/fast/media/print-video-crash-expected.txt: Added.
* LayoutTests/fast/media/print-video-crash.html: Added.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::printFrame):
(WebKit::WebPageProxy::endPrinting):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::endPrinting):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::endPrinting):
(WebKit::WebPage::endPrintingDuringDOMPrintOperation):
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::printFrame):

Originally-landed-as: 263022.8 at webkit-2023.4-embargoed (221c50b850f8). rdar://113402765
Canonical link: https://commits.webkit.org/266602@main


  Commit: 5b829ca404dfc0dcb728a8349e5690957788d85b
      https://github.com/WebKit/WebKit/commit/5b829ca404dfc0dcb728a8349e5690957788d85b
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-08-04 (Fri, 04 Aug 2023)

  Changed paths:
    A LayoutTests/fast/canvas/canvas-print-crash-expected.txt
    A LayoutTests/fast/canvas/canvas-print-crash.html

  Log Message:
  -----------
  Add test case for bug 251370
https://bugs.webkit.org/show_bug.cgi?id=251370

Reviewed by Chris Dumez.

Already fixed by https://commits.webkit.org/263022.8@webkit-2023.4-embargoed, but
add this test for completeness.

* LayoutTests/fast/canvas/canvas-print-crash-expected.txt: Added.
* LayoutTests/fast/canvas/canvas-print-crash.html: Added.

Originally-landed-as: 263022.9 at webkit-2023.4-embargoed (a0645306d06d). rdar://113402869
Canonical link: https://commits.webkit.org/266603@main


Compare: https://github.com/WebKit/WebKit/compare/85b79f4d702c...5b829ca404df