[webkit-changes] [WebKit/WebKit] 6d13b1: [import-w3c-tests] Normalize test_paths sooner

Sam Sneddon noreply at github.com
Fri Aug 4 12:03:45 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6d13b1672d0f7ce5a6f8093e1ed597e0bd0f2cf2
      https://github.com/WebKit/WebKit/commit/6d13b1672d0f7ce5a6f8093e1ed597e0bd0f2cf2
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2023-08-04 (Fri, 04 Aug 2023)

  Changed paths:
    M LayoutTests/imported/w3c/resources/import-expectations.json
    M Tools/Scripts/webkitpy/common/system/filesystem_mock.py
    M Tools/Scripts/webkitpy/common/system/filesystem_mock_unittest.py
    M Tools/Scripts/webkitpy/w3c/test_downloader.py
    M Tools/Scripts/webkitpy/w3c/test_importer.py
    M Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

  Log Message:
  -----------
  [import-w3c-tests] Normalize test_paths sooner
https://bugs.webkit.org/show_bug.cgi?id=259742
rdar://problem/113281074

Reviewed by Jonathan Bedard.

This moves the normalization from updating resource-files.json to the
start of the processing; this gives us a single form throughout the
entire importer.

* LayoutTests/imported/w3c/resources/import-expectations.json: remove redundant lines
* Tools/Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.dirs_under): Make the mock match the actual behaviour with a trailing slash.
* Tools/Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
(MockFileSystemTest.test_dirs_under): Test for the above.
* Tools/Scripts/webkitpy/w3c/test_downloader.py:
(TestDownloader.update_import_expectations): Normalize to no trailing slash.
* Tools/Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.do_import): Do the normalization sooner.
* Tools/Scripts/webkitpy/w3c/test_importer_unittest.py: Fix tests which currently path a string as test_paths.

Canonical link: https://commits.webkit.org/266595@main




More information about the webkit-changes mailing list