[webkit-changes] [WebKit/WebKit] 2aadd4: WebGLRenderingContexts should initialize all conte...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2aadd417b2ceeb22999ab366a12e1e55815be786
      https://github.com/WebKit/WebKit/commit/2aadd417b2ceeb22999ab366a12e1e55815be786
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-08-04 (Fri, 04 Aug 2023)

  Changed paths:
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.h
    M Source/WebCore/platform/graphics/GraphicsContextGL.h
    M Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp
    M Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h
    M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h

  Log Message:
  -----------
  WebGLRenderingContexts should initialize all context state in initializeNewContext()
https://bugs.webkit.org/show_bug.cgi?id=259731
rdar://113261547

Reviewed by Dan Glastonbury.

Move initialization of m_maxViewportDims, m_isDepthStencilSupported
to WebGLRenderingContextBase::initializeNewContext(). m_maxViewportDims
was not reinitialized consistently on context restore.

Removes isGLES2Compliant, it corresponds to isForWebGL2 flag.
Removes unused robustness flag query, robustness is always provided by
ANGLE.
Removes unused isGLES2NPOTStrict.

* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):
(WebCore::WebGLRenderingContextBase::checkForContextLossHandling):
(WebCore::WebGLRenderingContextBase::registerWithWebGLStateTracker):
(WebCore::WebGLRenderingContextBase::initializeNewContext):
(WebCore::WebGLRenderingContextBase::setupFlags):
(WebCore::WebGLRenderingContextBase::getActiveUniform):
(WebCore::WebGLRenderingContextBase::makeXRCompatible):
(WebCore::WebGLRenderingContextBase::maybeRestoreContext):
* Source/WebCore/html/canvas/WebGLRenderingContextBase.h:
(WebCore::WebGLRenderingContextBase::isGLES2Compliant): Deleted.
(WebCore::WebGLRenderingContextBase::isGLES2NPOTStrict): Deleted.
* Source/WebCore/platform/graphics/GraphicsContextGL.h:
* Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::isGLES2Compliant const): Deleted.
* Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::isGLES2Compliant const): Deleted.
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:

Canonical link: https://commits.webkit.org/266579@main