[webkit-changes] [WebKit/WebKit] 73105b: update-angle fails when due to program version id ...

Kimmo Kinnunen noreply at github.com
Thu Aug 3 23:08:04 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 73105b6a5a2e1b61e65db6d11b367b66123ddf4e
      https://github.com/WebKit/WebKit/commit/73105b6a5a2e1b61e65db6d11b367b66123ddf4e
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-08-03 (Thu, 03 Aug 2023)

  Changed paths:
    M Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
    M Source/ThirdParty/ANGLE/CMakeLists.txt
    M Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig
    A Source/ThirdParty/ANGLE/WebKit/ANGLEShaderProgramVersion.h
    A Source/ThirdParty/ANGLE/WebKit/angle_commit.h
    M Source/ThirdParty/ANGLE/changes.diff
    R Source/ThirdParty/ANGLE/src/angle_code_affecting_program_serialize.xcfilelist
    R Source/ThirdParty/ANGLE/src/angle_commit.h
    R Source/ThirdParty/ANGLE/src/common/ANGLEShaderProgramVersion.h
    M Tools/Scripts/update-angle

  Log Message:
  -----------
  update-angle fails when due to program version id update when upstream files are renamed
https://bugs.webkit.org/show_bug.cgi?id=259774
rdar://113324930

Unreviewed, to be reviewed by Dan Glastonbury.

angle_code_affecting_program_serialize.xcfilelist would have manually
curated files that affects the program version. In practice, this was
set to be just all the compiled ANGLE files. Since this list was
manually compiled, this would break frequently due to upstread renames.

Instead, compile the list with `find`.

Move generated files ANGLEShaderProgramVersion.h and angle_commit.h to
WebKit/ directory, so that they do not appear in changes.diff exclusion
list when generating the diff.

Clean up the parameters of the script and remove some redundant
printout.

* Source/ThirdParty/ANGLE/WebKit/ANGLEShaderProgramVersion.h: Added.
* Source/ThirdParty/ANGLE/WebKit/angle_commit.h: Renamed from Source/ThirdParty/ANGLE/src/angle_commit.h.
* Source/ThirdParty/ANGLE/changes.diff:
* Source/ThirdParty/ANGLE/src/angle_code_affecting_program_serialize.xcfilelist: Removed.
* Source/ThirdParty/ANGLE/src/common/ANGLEShaderProgramVersion.h: Removed.
* Tools/Scripts/update-angle:

Canonical link: https://commits.webkit.org/266571@main




More information about the webkit-changes mailing list