[webkit-changes] [WebKit/WebKit] 31a6df: AX: VoiceOver word echo doesn't work on text input...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 31a6df57125aab556100cf89203feedf28b4af24
      https://github.com/WebKit/WebKit/commit/31a6df57125aab556100cf89203feedf28b4af24
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-08-03 (Thu, 03 Aug 2023)

  Changed paths:
    A LayoutTests/accessibility/ios-simulator/text-input-combobox-expected.txt
    A LayoutTests/accessibility/ios-simulator/text-input-combobox.html
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
    M Tools/DumpRenderTree/AccessibilityUIElement.cpp
    M Tools/DumpRenderTree/AccessibilityUIElement.h
    M Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl
    M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm

  Log Message:
  -----------
  AX: VoiceOver word echo doesn't work on text inputs with a combobox role
https://bugs.webkit.org/show_bug.cgi?id=259811
rdar://112488137

Reviewed by Chris Fleizach.

This happens because prior to this patch, we didn't expose the text
entry trait for comboboxes, despite comboboxes generally (but not
always) being a combination of a text input, plus a listbox of possible
options.

With this patch, when a text input has a role of combobox, we expose the
text entry trait.

* LayoutTests/accessibility/ios-simulator/combobox-is-editable-expected.txt: Added.
* LayoutTests/accessibility/ios-simulator/combobox-is-editable.html: Added.
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityTraits]):
* Tools/DumpRenderTree/AccessibilityUIElement.cpp:
(hasTextEntryTraitCallback):
(AccessibilityUIElement::getJSClass):
* Tools/DumpRenderTree/AccessibilityUIElement.h:
* Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::hasTextEntryTrait):
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::hasTextEntryTrait):
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::hasTextEntryTrait):

Canonical link: https://commits.webkit.org/266569@main