[webkit-changes] [WebKit/WebKit] e4772f: Media Controls: Volume slider should always show i...

Richard Robinson noreply at github.com
Thu Aug 3 19:16:08 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e4772fad1ca24d48d3d2fd2bcfd313fd6c4dcccf
      https://github.com/WebKit/WebKit/commit/e4772fad1ca24d48d3d2fd2bcfd313fd6c4dcccf
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-08-03 (Thu, 03 Aug 2023)

  Changed paths:
    M Source/WebCore/DerivedSources-input.xcfilelist
    M Source/WebCore/DerivedSources.make
    M Source/WebCore/Modules/modern-media-controls/controls/vision-media-controls.css
    M Source/WebCore/Modules/modern-media-controls/controls/vision-media-controls.js
    A Source/WebCore/Modules/modern-media-controls/controls/vision-volume-container.js
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Media Controls: Volume slider should always show if we have enough room
https://bugs.webkit.org/show_bug.cgi?id=259721
rdar://113243353

Reviewed by Dean Jackson.

On visionOS, the volume slider should always show within inline video, if there is enough room.

* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Modules/modern-media-controls/controls/vision-media-controls.css:
(.media-controls.vision > .controls-bar.top-right,):
(.media-controls.vision > .controls-bar.top-right):
(.media-controls.vision .controls-bar.simple-layout .volume-container > .slider.vision.volume,):
(.media-controls.vision .controls-bar.simple-layout.top-right > .overflow):
(.media-controls.vision .volume-container):
(.media-controls.vision .volume-container > .mute.bar):
(.media-controls.vision:not(.audio) .volume-container > .background-tint > .blur,):
(.media-controls.vision.fullscreen > .controls-bar.top-right,): Deleted.
(.media-controls.vision.fullscreen > .controls-bar.top-right): Deleted.
(.media-controls.vision .controls-bar.simple-layout > *:not(.background-tint)): Deleted.
(.media-controls.vision:not(.audio) button > .background-tint > .blur): Deleted.
* Source/WebCore/Modules/modern-media-controls/controls/vision-media-controls.js:
(VisionMediaControls.prototype._createControls):
(VisionMediaControls.prototype._performVolumeContainerLayout):
(VisionMediaControls.prototype._performTopRightControlsBarLayout):
(VisionInlineMediaControls.prototype._createControls):
(VisionInlineMediaControls.prototype._performLayout):
(VisionInlineMediaControls.prototype._topRightControlsBarChildren):
(VisionInlineMediaControls.prototype._performVolumeContainerLayout):
(VisionFullscreenMediaControls.prototype._createControls):
(VisionFullscreenMediaControls.prototype._performVolumeContainerLayout):
(VisionFullscreenMediaControls.prototype._topRightControlsBarChildren):
* Source/WebCore/Modules/modern-media-controls/controls/vision-volume-container.js: Added.
(VolumeContainer.prototype.get children):
(VolumeContainer.prototype.set children):
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/266566@main




More information about the webkit-changes mailing list