[webkit-changes] [WebKit/WebKit] 9809c1: SHA1.h doesn't parse after recent SDK changes

Tim Horton noreply at github.com
Thu Aug 3 16:50:25 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9809c1a27c826cd1bd8b942b2d254de33a288a56
      https://github.com/WebKit/WebKit/commit/9809c1a27c826cd1bd8b942b2d254de33a288a56
  Author: Tim Horton <thorton at apple.com>
  Date:   2023-08-03 (Thu, 03 Aug 2023)

  Changed paths:
    M Source/WTF/wtf/SHA1.h

  Log Message:
  -----------
  SHA1.h doesn't parse after recent SDK changes
https://bugs.webkit.org/show_bug.cgi?id=259800
rdar://113360320

Reviewed by Megan Gardner and Wenson Hsieh.

* Source/WTF/wtf/SHA1.h:
Recent SDK changes resulted in CoreUtils headers getting imported into
translation units (MediaPlayerPrivateWebM.mm) that also import `SHA1.h`.

The aforementioned CoreUtils headers have long had a macro SHA1(),
which conflict with our template functions' definitions, and make SHA1.h
fail to parse.

As a quick workaround, undefine the rogue macros before our SHA1 class.

Canonical link: https://commits.webkit.org/266559@main




More information about the webkit-changes mailing list