[webkit-changes] [WebKit/WebKit] cf2cae: CSS Custom Highlights WPT painting 008 fail due to...

Jessica Cheung noreply at github.com
Thu Aug 3 13:45:29 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf2caed3a2f91074568bb267dfa85aae0a6112bd
      https://github.com/WebKit/WebKit/commit/cf2caed3a2f91074568bb267dfa85aae0a6112bd
  Author: Jessica Cheung <jcheung23 at apple.com>
  Date:   2023-08-03 (Thu, 03 Aug 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/Modules/highlight/Highlight.idl
    M Source/WebCore/bindings/js/JSDOMSetLike.h

  Log Message:
  -----------
  CSS Custom Highlights WPT painting 008 fail due to not initializing SetLike before removal
https://bugs.webkit.org/show_bug.cgi?id=259755
rdar://113300782

Reviewed by Chris Dumez.

Before setlike removal, backingSet was never initialized,
thus not matching the setlike in implementation leading to crash due to
failing assertion.
Removed outdated fixme comment in highlight idl.

* LayoutTests/TestExpectations:
* Source/WebCore/Modules/highlight/Highlight.idl:
* Source/WebCore/bindings/js/JSDOMSetLike.h:
(WebCore::forwardDeleteToSetLike):

Canonical link: https://commits.webkit.org/266552@main




More information about the webkit-changes mailing list