[webkit-changes] [WebKit/WebKit] 9bd05b: dtoa/utils.h doesn't parse after recent SDK changes

Tim Horton noreply at github.com
Thu Aug 3 13:21:04 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9bd05bda44cc97b986fda68ad5a0a1cf9fef0f1c
      https://github.com/WebKit/WebKit/commit/9bd05bda44cc97b986fda68ad5a0a1cf9fef0f1c
  Author: Tim Horton <thorton at apple.com>
  Date:   2023-08-03 (Thu, 03 Aug 2023)

  Changed paths:
    M Source/WTF/wtf/dtoa/utils.h

  Log Message:
  -----------
  dtoa/utils.h doesn't parse after recent SDK changes
https://bugs.webkit.org/show_bug.cgi?id=259789
rdar://113341253

Reviewed by Wenson Hsieh.

* Source/WTF/wtf/dtoa/utils.h:
Recent SDK changes resulted in CoreUtils headers getting imported into
translation units (OutputContext.mm) that also import `dtoa/utils.h`.

The aforementioned CoreUtils headers have long had macros Min() and Max(),
which conflict with our template functions' definitions, and make utils.h
fail to parse.

As a quick workaround, undefine the rogue macros before our Min() and Max().

Canonical link: https://commits.webkit.org/266550@main




More information about the webkit-changes mailing list