[webkit-changes] [WebKit/WebKit] 078e59: [visionOS] Crash when entering fullscreen on vimeo...
Aditya Keerthi
noreply at github.com
Thu Aug 3 12:48:07 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 078e59c40257b11569b27fd8c39928271a25d64f
https://github.com/WebKit/WebKit/commit/078e59c40257b11569b27fd8c39928271a25d64f
Author: Aditya Keerthi <akeerthi at apple.com>
Date: 2023-08-03 (Thu, 03 Aug 2023)
Changed paths:
M Source/WebCore/platform/ios/WebAVPlayerController.h
M Source/WebCore/platform/ios/WebAVPlayerController.mm
Log Message:
-----------
[visionOS] Crash when entering fullscreen on vimeo.com
https://bugs.webkit.org/show_bug.cgi?id=259785
rdar://113227148
Reviewed by Richard Robinson.
Recent changes in AVKit result in an underlying framework relying on
`-[AVMediaSelectionOption displayName]`, which is in the public interface.
Fix the crash by implementing `-displayName` on our "proxy" object, `WebAVMediaSelectionOption`.
* Source/WebCore/platform/ios/WebAVPlayerController.h:
* Source/WebCore/platform/ios/WebAVPlayerController.mm:
(-[WebAVMediaSelectionOption displayName]):
`displayName` is intended to be localized, so simply return the existing localized property.
Canonical link: https://commits.webkit.org/266548@main
More information about the webkit-changes
mailing list