[webkit-changes] [WebKit/WebKit] c85962: Fails to build with GCC 13 due to overloaded-virtu...

Thu Aug 3 04:16:24 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c85962a5c0e929991e5963811da957b75d1501db
      https://github.com/WebKit/WebKit/commit/c85962a5c0e929991e5963811da957b75d1501db
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-08-03 (Thu, 03 Aug 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/filters/FELighting.h

  Log Message:
  -----------
  Fails to build with GCC 13 due to overloaded-virtual error in FilterEffect
https://bugs.webkit.org/show_bug.cgi?id=259729

Reviewed by Said Abou-Hallawa.

FilterEffect.h:44:18: error: ‘virtual bool WebCore::FilterEffect::operator==(const WebCore::FilterEffect&) const’ was hidden [-Werror=overloaded-virtual=]
   44 |     virtual bool operator==(const FilterEffect&) const;
      |                  ^~~~~~~~
FELighting.h:42:10: note:   by ‘bool WebCore::FELighting::operator==(const WebCore::FELighting&) const’
   42 |     bool operator==(const FELighting&) const;
      |          ^~~~~~~~

* Source/WebCore/platform/graphics/filters/FELighting.h:

Canonical link: https://commits.webkit.org/266539@main