[webkit-changes] [WebKit/WebKit] 9646bf: Add logging when SQLite transaction fails to start

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9646bf57444f2b10651b26f9ed9ca34d3e4e374b
      https://github.com/WebKit/WebKit/commit/9646bf57444f2b10651b26f9ed9ca34d3e4e374b
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-08-02 (Wed, 02 Aug 2023)

  Changed paths:
    M Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp
    M Source/WebCore/platform/sql/SQLiteDatabase.cpp
    M Source/WebCore/platform/sql/SQLiteDatabase.h
    M Source/WebCore/platform/sql/SQLiteTransaction.cpp

  Log Message:
  -----------
  Add logging when SQLite transaction fails to start
https://bugs.webkit.org/show_bug.cgi?id=259612
rdar://113048804

Reviewed by Chris Dumez.

It's possible that a database is simultaneously accessed by two processes, and transaction fails to start with
SQLITE_BUSY error. Add error log to help us discover these cases.

* Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::getOrEstablishDatabaseInfo):
* Source/WebCore/platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::executeSlow):
(WebCore::SQLiteDatabase::execute):
(WebCore::SQLiteDatabase::executeCommandSlow):
(WebCore::SQLiteDatabase::executeCommand):
* Source/WebCore/platform/sql/SQLiteDatabase.h:
* Source/WebCore/platform/sql/SQLiteTransaction.cpp:
(WebCore::SQLiteTransaction::begin):

Canonical link: https://commits.webkit.org/266520@main