[webkit-changes] [WebKit/WebKit] 83a656: [ macOS Debug WK2 ] ASSERT call in RenderVTTCue.cp...

Wed Aug 2 08:56:55 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 83a6562ec0c7855fbbeb1f50ea2f16034c504317
      https://github.com/WebKit/WebKit/commit/83a6562ec0c7855fbbeb1f50ea2f16034c504317
  Author: Eric Carlson <eric.carlson at apple.com>
  Date:   2023-08-02 (Wed, 02 Aug 2023)

  Changed paths:
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebCore/rendering/RenderVTTCue.cpp

  Log Message:
  -----------
  [ macOS Debug WK2 ] ASSERT call in RenderVTTCue.cpp causing flaky crash (media/modern-media-controls/tracks-support/text-track-selected-via-media-api.html)
https://bugs.webkit.org/show_bug.cgi?id=259544
rdar://112951082

Reviewed by Jer Noble.

Remove two unneeded asserts. Both checked a condition that is commonly encountered and which
is not dangerous or harmful.

* LayoutTests/platform/mac-wk2/TestExpectations: Unskip test.

* Source/WebCore/rendering/RenderVTTCue.cpp:
(WebCore::RenderVTTCue::repositionCueSnapToLinesSet): Remove assert.
(WebCore::RenderVTTCue::repositionGenericCue): Ditto.

Canonical link: https://commits.webkit.org/266513@main