[webkit-changes] [WebKit/WebKit] 476e8f: REGRESSION(262797 at main): Menu permanently opened o...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 476e8fbe38b048c71cec9587579ad59d1d8dbb32
      https://github.com/WebKit/WebKit/commit/476e8fbe38b048c71cec9587579ad59d1d8dbb32
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-08-02 (Wed, 02 Aug 2023)

  Changed paths:
    M Source/WebKit/Shared/WebPreferencesDefaultValues.cpp

  Log Message:
  -----------
  REGRESSION(262797 at main): Menu permanently opened on github.com
https://bugs.webkit.org/show_bug.cgi?id=258290

Reviewed by Michael Catanzaro.

In 262797 at main popover attribute was disabled for apple apps linkking to
the older SDKs, but also for non-apple ports. What happens in github now
is that the popover is never hidden because display: revert ends up in
block. This is because the popover css, which sets display: none when
popover-open is not present, is not included for any element.

* Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultPopoverAttributeEnabled): Enable it by default for non-apple ports again.

Canonical link: https://commits.webkit.org/266510@main